search

samuel-pratt / bc-ferries-api

🛳 The only public API for retrieving current data on BC Ferries sailings.
https://bcferriesapi.ca
MIT License
34 stars 11 forks source link

Add/bowen to horseshoe bay #4

Closed enejb closed 3 years ago

enejb commented 3 years ago

This PR tries to add the Bowen Island Snug Cove to Housershoe bay route

How has it been tested?

Run 

python scraper.py

Notice that the string contains the expected data.

Screen Shot 2020-12-19 at 6 52 51 PM

Note: I think it would be good to remove the departures that are in the past the just like in other routes. This is currently not the case.

I am new to python so any feedback on the PR is greatly appreciated :)

samuel-pratt commented 3 years ago

The scraper changes look good to me! When adding a route make sure to also add it to app.py so the api can support it as well, and also add it to the list of valid routes on the readme.

For removing past departures, we could check if the departure time is before the current time, and if so remove it. This could be saved for a future pr though.

samuel-pratt commented 3 years ago

I added dashes to the terminal names in app.py, besides that all looks good!

enejb commented 3 years ago

Thank for the feedback and all the fixes.