search

samuel / go-thrift

A native Thrift package for Go
BSD 3-Clause "New" or "Revised" License
384 stars 110 forks source link

Allow Thrift byte type to be rendered as Go int8 type. #85

Closed anxiousmodernman closed 8 years ago

anxiousmodernman commented 8 years ago

This is related the discussion in #84

I added a struct field to GoGenerator. Seems better to set it on the struct and use that throughout the code.

I have made a new subfolder for the generator tests related to this command line flag. I opted not to copy all of the existing tests into this subfolder.

/testfiles
  /generator
    /withFlags
      /go.signedbytes
        bytes.go
        bytes.thrift

If that's not optimal, we can talk about another strategy for the generator tests.

samuel commented 8 years ago

Awesome, looks great. Thanks!