max buffer size - Githubissues

samuel / go-zookeeper

Native ZooKeeper client for Go. This project is no longer maintained. Please use https://github.com/go-zookeeper/zk instead.

BSD 3-Clause "New" or "Revised" License

1.64k stars 672 forks source link

max buffer size #166

Closed jhump closed 7 years ago

jhump commented 7 years ago

Introduces a connection option that allows limiting the size of response packets that are buffered in the client. This matches the implementation of Jute in Java, which is the IDL and serialization format ZK uses.

coveralls commented 7 years ago

Coverage decreased (-0.3%) to 80.858% when pulling 7fb4a7666e88d729d3d798a3857454e86b3fb0a6 on jhump:jh/max-buffer-size into 1d7be4effb13d2d908342d349d71a284a7542693 on samuel:master.

coveralls commented 7 years ago

Coverage increased (+0.4%) to 81.609% when pulling b8bfa39fa60bee3dd22b5108b1db979150b833ad on jhump:jh/max-buffer-size into 1d7be4effb13d2d908342d349d71a284a7542693 on samuel:master.

coveralls commented 7 years ago

Coverage increased (+0.4%) to 81.609% when pulling b8bfa39fa60bee3dd22b5108b1db979150b833ad on jhump:jh/max-buffer-size into 1d7be4effb13d2d908342d349d71a284a7542693 on samuel:master.

coveralls commented 7 years ago

Coverage increased (+0.2%) to 81.354% when pulling 0bc033b55edc5a331ddb281cd5df5f7b9b76b4cf on jhump:jh/max-buffer-size into 1d7be4effb13d2d908342d349d71a284a7542693 on samuel:master.

jhump commented 7 years ago

@samuel, mind taking a look at this?

samuel commented 7 years ago

Looks great. Thanks for submitting and the thorough tests.