idempotent Close; queueRequest guards against deadlocks on closed connections

samuel / go-zookeeper

Native ZooKeeper client for Go. This project is no longer maintained. Please use https://github.com/go-zookeeper/zk instead.

BSD 3-Clause "New" or "Revised" License

1.64k stars 672 forks source link

idempotent Close; queueRequest guards against deadlocks on closed connections #183

Open jdef opened 6 years ago

jdef commented 6 years ago

fixes #148

coveralls commented 6 years ago

Coverage increased (+0.3%) to 43.353% when pulling cc6f56c50b37dfb404a173c64206d9d5290df2a4 on jdef:jdef/zkclose into 471cd4e61d7a78ece1791fa5faa0345dc8c7d5a5 on samuel:master.

coveralls commented 6 years ago

Coverage increased (+37.6%) to 80.588% when pulling f1083c7e8fce527a84910dace1d0b26ec11fc485 on jdef:jdef/zkclose into 471cd4e61d7a78ece1791fa5faa0345dc8c7d5a5 on samuel:master.

coveralls commented 6 years ago

Coverage increased (+0.2%) to 80.266% when pulling dd6d4dd6d0abcda16105e0b81c25b9cfdfe8f635 on jdef:jdef/zkclose into c4fab1ac1bec58281ad0667dc3f0907a9476ac47 on samuel:master.

jdef commented 6 years ago

rebased to master

jdef commented 6 years ago

@samuel PTAL

atavakoli commented 5 years ago

@samuel We're currently experiencing the #148 panics in our projects and would love to see this merged!

grantstephens commented 4 years ago

Any reason this seems to have stalled? Happy to take it over if that is ok?