search

samuel / go-zookeeper

Native ZooKeeper client for Go. This project is no longer maintained. Please use https://github.com/go-zookeeper/zk instead.
BSD 3-Clause "New" or "Revised" License
1.64k stars 672 forks source link

zk package imports "testing" #217

Closed aaronbee closed 5 years ago

aaronbee commented 5 years ago

zk/server_java.go imports "testing". This means that any binary using this library is going to be building with the Go testing library included.

samuel commented 5 years ago

Yeah, good point. Thanks for bringing that up. I renamed those files to _test which is a bit of a breaking change since someone might have been relying on them being exported, but seems better to make them just build in tests since they can always be moved to another package if needed.