Add TLS support with ConnectTLS function

samuel / go-zookeeper

Native ZooKeeper client for Go. This project is no longer maintained. Please use https://github.com/go-zookeeper/zk instead.

BSD 3-Clause "New" or "Revised" License

1.64k stars 672 forks source link

Add TLS support with ConnectTLS function #227

Open linalinn opened 4 years ago

linalinn commented 4 years ago

Hello, I added the function ConnectTLS to enable go-zookeeper to connect to TLS protected zookeepers. Also I did refactor the Connect func to prevent code redundancy.

coveralls commented 4 years ago

Coverage decreased (-0.4%) to 79.239% when pulling f062beae3aa6764da0852e908c3d36c72344113d on linalinn:tls into 2cc03de413da42869e2db7ce7965d3e978d917eb on samuel:master.

linalinn commented 4 years ago

I don't understand the DeepSource error. Can someone please help me with that?

linalinn commented 4 years ago

So I fixed the DeeSource Problems. But i can't add a test for Zookeeper with tls because i don't understand how the test is configuring the Zookeeper for a test. And isn't WithDialer() makred as depracated? so implementing TLS over WithDialer() would be wrong or not?

linalinn commented 4 years ago

Hello, I have a problem with fixing this DeepSource fail. I have tried it with adjusting the code like DeepSource suggested it. Any suggestions how to solve this problem?