samuel / go-zookeeper

Native ZooKeeper client for Go. This project is no longer maintained. Please use https://github.com/go-zookeeper/zk instead.
BSD 3-Clause "New" or "Revised" License
1.64k stars 672 forks source link

added a validation to check whether lock exists in case of network pa… #230

Open continuum-Nikhil-Bhide opened 4 years ago

continuum-Nikhil-Bhide commented 4 years ago

This addresses https://github.com/samuel/go-zookeeper/issues/229

continuum-Nikhil-Bhide commented 4 years ago

IT seems that CI is failing on the make command. FAIL github.com/samuel/go-zookeeper/zk 500.019s Makefile:37: recipe for target 'test' failed make: *** [test] Error 1 The command "make" exited with 2.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-1.4%) to 78.222% when pulling 3853affe94928ca20d927a954d55cf6fa638cd36 on continuum-Nikhil-Bhide:zk_229_lock_deadlock into 2cc03de413da42869e2db7ce7965d3e978d917eb on samuel:master.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.3%) to 79.886% when pulling 628889403ed863193ce86236f1ddccf5738c3e15 on continuum-Nikhil-Bhide:zk_229_lock_deadlock into 2cc03de413da42869e2db7ce7965d3e978d917eb on samuel:master.

continuum-Nikhil-Bhide commented 4 years ago

Hi Samuel, Requesting you to verify this change and approve the merge.