search

samuel / go-zookeeper

Native ZooKeeper client for Go. This project is no longer maintained. Please use https://github.com/go-zookeeper/zk instead.
BSD 3-Clause "New" or "Revised" License
1.64k stars 672 forks source link

Why clear timeout when read a response from server? #257

Open opriz opened 3 years ago

opriz commented 3 years ago

I found this line in conn.go

https://github.com/samuel/go-zookeeper/blob/master/zk/conn.go#L717 c.conn.SetReadDeadline(time.Time{})

In my view, if there occurs a problem in the network or server, clear the timeout deadline may cause this goroutine stuck for a long time even forever, then others stuck too because of the channel.

I wonder why it was written like this, was there some reason I've missed it? If necessary, I'd like to post an mr.

blizard863 commented 3 years ago

I also meet this problem.