build fails for mingw - Githubissues

samuel2015 / sparsehash

Automatically exported from code.google.com/p/sparsehash

BSD 3-Clause "New" or "Revised" License

0 stars 0 forks source link

build fails for mingw #48

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?
1. attempt to compile using msys

http://groups.google.com/group/google-
sparsehash/browse_thread/thread/b0ddb3f8c611f751

Original issue reported on code.google.com by rogerpack2005 on 15 Dec 2009 at 12:59

GoogleCodeExporter commented 9 years ago

I think the right fix is to change the WIN32 #ifdef to _MSC_VER, in 
hasthable_unittest.cc.  I'll make that part of the next release.

Original comment by csilv...@gmail.com on 15 Dec 2009 at 2:01

Changed state: Started
Added labels: Priority-Medium, Type-Defect
Removed labels: ****

GoogleCodeExporter commented 9 years ago

#ifndef _MSC_VER 

seems to do the trick thanks!
-r

Original comment by rogerpack2005 on 15 Dec 2009 at 1:57

Added labels: ****
Removed labels: ****

GoogleCodeExporter commented 9 years ago

This should be resolved in sparsehash 1.6, just released.

Original comment by csilv...@gmail.com on 11 Jan 2010 at 10:53

Changed state: Fixed
Added labels: ****
Removed labels: ****

GoogleCodeExporter commented 9 years ago

appears to build like a champ now

Original comment by rogerpack2005 on 12 Jan 2010 at 5:37

Added labels: ****
Removed labels: ****