search

samuela / rustybox

A free-range, non-GMO fork of busybox in 100% Rust 🦀
811 stars 33 forks source link

Possibly clearer applet_tables #20

Closed Akeboshiwind closed 4 years ago

Akeboshiwind commented 4 years ago

Do you think it would be clearer if the entrypoints used the full path names (here)[https://github.com/samuela/rustybox/blob/master/applets/applet_tables.rs#L424]?

Great work in cleaning up that file btw, it looks great now.

samuela commented 4 years ago

Do you mean using crate::...::main_func instead of use imports?

Akeboshiwind commented 4 years ago

Yeah.

The alternative is just using editor navigation or just scrolling up. Neither of which are bad options.

On Sun, 26 Jan 2020, 17:48 samuela, notifications@github.com wrote:

Do you mean using crate::...::main_func instead of use imports?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/samuela/rustybox/issues/20?email_source=notifications&email_token=ACD2NATSRE53JT2J7UQ7VSTQ7XEGBA5CNFSM4KLWOL2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ5ZUKA#issuecomment-578525736, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACD2NAVPL7MY63FXMYUMZFLQ7XEGBANCNFSM4KLWOL2A .

samuela commented 4 years ago

Yeah I think the full crate names would be better, esp. since that will also fix the "unused import" warnings when using feature flags.

samuela commented 4 years ago

Ok, should be fixed in 571301140f6462ba5fe193050aade00a388f2cd4.