samuelcheongws / pe

0 stars 0 forks source link

Overzealous input validation for addition of names #2

Open samuelcheongws opened 2 years ago

samuelcheongws commented 2 years ago

Inputs such as Ravi S/O Balakrishnan Son Heung-min South Korean football player Martin Luther King Jr. are not accepted.

Since this is a financial advisor application where the personal data of the client cannot be spelt wrongly or without spaces, it is highly important for valid legal names such as the above to be accpeted. This should be accounted for, or at least specified as a limitation in the UG.

The UG mentioned that "Parameter restrictions : Only standard English characters are allowed, and it should not be blank." However we can consider / . - standard english characters.

image.png

image.png

image.png

nus-se-script commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Name field does not support "s/o" names

The name field does not support "s/o" which is in many people's names

image.png


[original: nus-cs2103-AY2223S1/pe-interim#4228] [original labels: type.FeatureFlaw severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]