search

samuelclay / NewsBlur

NewsBlur is a personal news reader that brings people together to talk about the world. A new sound of an old instrument.
http://www.newsblur.com
MIT License
6.87k stars 1k forks source link

iOS: Add peek preview on long press of story links #1386

Open lamnatos opened 3 years ago

lamnatos commented 3 years ago

I can't remember when it started happening but tap & holding links is not working as it should in NewsBlur.

Tap & hold on a link in any other app in iOS brings up the peek preview (I think it's called) of the link. It's the pop over that allows for example to share or copy the link destination. For example in Mail.app:

405A48AC-AC0A-47B6-8BF6-E284D6505901

In NewsBlur app it selects the text like it's any other non-link text, only giving the regular text options like copy text, define, dictate etc. This is what happens in NewsBlur:

BBE5C04F-4019-45F9-B37B-4C3127038772

samuelclay commented 3 years ago

I agree, we should do a peek on long pressing links in stories.

Dejal commented 4 weeks ago

This is a tricky one; I've investigated a couple of times, without success. The link preview does work in the simpler in-app browser, but something in the story web view is breaking it; I've tried stripping out the gesture recognizers, custom menus, JavaScript, etc, without making a difference. I'm sure I'll figure it out one day!