search

samuelclay / NewsBlur

NewsBlur is a personal news reader that brings people together to talk about the world. A new sound of an old instrument.
http://www.newsblur.com
MIT License
6.83k stars 996 forks source link

Hacker News Comments Link Broken #293

Closed manderson23 closed 11 years ago

manderson23 commented 11 years ago

As mentioned at https://getsatisfaction.com/newsblur/topics/hacker_news_feed_parsing_broken (and I think a couple of other times) the comments link in the Hacker News feed is broken due to some encoding changes they made recently.

They seem to be using / to encode /. However the story links also use this encoding and they are handled properly.

Surely there must be a way to handle this for the comments link?

samuelclay commented 11 years ago

Logged it on the Hacker News github issue tracker: https://github.com/HackerNews/HN/issues/2

manderson23 commented 11 years ago

FWIW I think it would be good if you could get the fix from the library you use in before the Google Reader shutdown. I could see some new users complaining about this.

PrplHaz4 commented 11 years ago

I think this actually causes the android app to crash too - happens consistently on the Hacker News 50 feed.

samuelclay commented 11 years ago

Problem is by using latest feedparser, it breaks a bunch of other things. I give it a try every now and then and find it creates a lot of backend hassle. I'll try it again soon, though. Pester me if this doesn't happen soon enough.

PrplHaz4 commented 11 years ago

No worries man, keep kicking ass!

manderson23 commented 11 years ago

Thanks for getting this resolved Samuel.

samuelclay commented 11 years ago

Took a few weeks, but I ended up convincing the HN maintainer to not encode the URLs. But his fix for feedparser is interesting, although it may be overkill.