iOS doesn't use SSL for login (or anything else)

samuelclay / NewsBlur

NewsBlur is a personal news reader that brings people together to talk about the world. A new sound of an old instrument.

http://www.newsblur.com

MIT License

6.92k stars 1k forks source link

iOS doesn't use SSL for login (or anything else) #305

Closed pabloav closed 11 years ago

pabloav commented 11 years ago

I was working on your xkcd challenge on iOS and looking at the code for the first time. I was a little surprised to see you're not using SSL anywhere, not even for login. I committed a change to my fork that moves the URL schema into NEWSBLUR_URL (making it https://www.newsblur.com) and introduces NEWSBLUR_HOST (for the connectivity test).

pabloav/NewsBlur master branch, commit 975c9de0bb9b8a91a4c5dddbe57efa51b10df4c7

I didn't do a pull request because I thought the changes would be a little more dramatic than you would consider. -Pablo

samuelclay commented 11 years ago

Send it over, it looks great. I'd be happy to integrate that.

pabloav commented 11 years ago

Ok I'll do a pull request a little later (I'm still getting used to that). Not to put too fine a point on it: my patch will greatly increase the volume of https requests you're currently getting. Hopefully it won't cause any issues.

On Jun 19, 2013, at 12:31 AM, Samuel Clay notifications@github.com wrote:

Send it over, it looks great. I'd be happy to integrate that.

— Reply to this email directly or view it on GitHubhttps://github.com/samuelclay/NewsBlur/issues/305#issuecomment-19662513 .

samuelclay commented 11 years ago

Closed in #307.