search

samuelclay / NewsBlur

NewsBlur is a personal news reader that brings people together to talk about the world. A new sound of an old instrument.
http://www.newsblur.com
MIT License
6.92k stars 1k forks source link

Android: Incorrect Font Size Handling on 4.4 #433

Closed dosiecki closed 11 years ago

dosiecki commented 11 years ago

https://getsatisfaction.com/newsblur/topics/tiny_text_on_nexus_7_with_kitkat

manderson23 commented 11 years ago

Presumably this is related to #392 but made worse by changes in 4.4?

manderson23 commented 11 years ago

Just updated to 4.4 and I can confirm that the default is smaller. I can also confirm there are issues with adjusting the text size like was mentioned in the get satisfaction thread.

@dosiecki have you looked at this at all? If not I can start working on it.

dosiecki commented 11 years ago

I finally got my hands on a Nexus 5 to play with yesterday.

The only bug I saw is that the default setting claims to be on XL, but the font is actually M. Once you adjust the slider at all, settings stuck and appeared to correspond correctly. That is to say, compared to normal device font sizes, XS and S were a little on the small side, L and XL were a little on the large side.

I'd love to see some screenshots from other devices that are experiencing the tiny text.

One potentially impacting behaviour I have confirmed on several devices is that we don't respect system-wide font adjustments. Though we do use sp units so font sizes are relative to screen density, we could do one better and make our sizes offsets from the system neutral size?

manderson23 commented 11 years ago

The selected font size wasn't been set correctly when a web view was first opened. I'm about to submit a pull request to fix this. As you say when the adjust the settings it did update correctly but only for the currently open story view.

I don't really have an issue with the font sizes but I think you are right that we could do more in this area to respect system fonts and perhaps give users more flexibility in the range of sizes they can use.

dosiecki commented 11 years ago

Double checked that this is back to working on 4.4 with the latest patch. There are still issues with font sizing when the browser is taken out of quirks mode, but that is being tracked in #441.