search

samuelclay / NewsBlur

NewsBlur is a personal news reader that brings people together to talk about the world. A new sound of an old instrument.
http://www.newsblur.com
MIT License
6.92k stars 1k forks source link

Android: Use system preference to show time as 12/24 hours #483

Closed manderson23 closed 10 years ago

manderson23 commented 10 years ago

After seeing this feature I added to the web I think it would be nice to have it in the Android app. Instead of our own preference we should just be able to use the system setting.

samuelclay commented 10 years ago

Ok, it's important that we get the logic to look the same. There are two strings we use: long_parsed_date and short_parsed_date. I have three different implementations of it, so pick you favorite and please give it the exact same treatment in Java.

Python: https://github.com/samuelclay/NewsBlur/blob/master/utils/story_functions.py#L33-L59 Objective-C: https://github.com/samuelclay/NewsBlur/blob/master/clients/ios/Classes/Utilities.m#L167-L263 JavaScript: https://github.com/samuelclay/NewsBlur/blob/master/media/js/newsblur/models/stories.js#L36-L95

samuelclay commented 10 years ago

JavaScript is the newest one and is the one I recommend using as your reference.

manderson23 commented 10 years ago

Thanks Samuel.