search

samuelclay / NewsBlur

NewsBlur is a personal news reader that brings people together to talk about the world. A new sound of an old instrument.
http://www.newsblur.com
MIT License
6.83k stars 995 forks source link

Android: why does the feed list redraw when I finish reading a story? #629

Closed samuelclay closed 9 years ago

samuelclay commented 9 years ago

I'm reading a story, hit the Done button, and get taken back to an empty feed list that takes a half second to populate.

dosiecki commented 9 years ago

It doesn't always, but it can. It is up to the system whether to preserve that view or to save state and recycle it to save memory. In the latter case, there will be a delay when you go back to it. Apps have little to no control over whether or not the system elects to recycle views not in the foreground.

samuelclay commented 9 years ago

I feel like Feedly and Press never redraw their screens. Even going into a story is much quicker. What can we do about this UI glitchiness?

samuelclay commented 9 years ago

So you know, after using both of those competing apps for a bit, I'm thrilled to say how much nicer and more polished the NewsBlur android app feels. But one thing that needs to be fixed is the visual redraws. It's partly this and partly #630.

dosiecki commented 9 years ago

I know that our stack-jumping button [1] does defeat activity re-use on some devices, but I have no idea how widespread this is. (on my devices, I only see the feed list draw from scratch if I spend a long time in reading view) We will need to see if there is any way around this.

[1] Normally the order we view activities is M->L->R->L->M, and the system understands the push-push-pop-pop case well. Our "done" button, though, causes us to jump an item and go M->L->R->M, and the system gets confused about whether the M activity is the same one as before, since we didn't pop the activity stack one at a time. (where M=Main, L=List, R=Reading)

samuelclay commented 9 years ago

This also happens on the story list (feed detail). User talks about it here: https://getsatisfaction.com/newsblur/topics/returning-to-all-stories-always-starts-from-the-beginning-of-the-list-on-android.

Thing is, we used to preserve position. Can you change this so that the view scrolls to where the last selected story is when you go back to the story list from the story detail?

vgivanovic commented 9 years ago

@samuelclay Thanks for articulating what the real issue is much more succinctl than I did!

dosiecki commented 9 years ago

Fixed in #662 on all devices with sufficient memory.

dosiecki commented 9 years ago

Can you change this so that the view scrolls to where the last selected story is when you go back to the story list from the story detail?

This was fixed some months ago. Again, though, the system can throw out the old state if it needs to recover memory. I just tested this on three devices and the position was maintained on all of them. If this can be repro'd on a healthy device, please file a new issue (this one is not strictly related).