Use fieldnames method instead of accessing the field directly which fails on master.

samuelcolvin / Bokeh.jl

Bokeh Bindings for Julia

Other

46 stars 14 forks source link

Use fieldnames method instead of accessing the field directly which fails on master. #21

Closed andreasnoack closed 9 years ago

samuelcolvin commented 9 years ago

Thanks looks good.

Still some tests failing for nightly: https://travis-ci.org/bokeh/Bokeh.jl/jobs/64192727

Might as well fix them all at the same time.

andreasnoack commented 9 years ago

Ok. I've made some further changes so the tests are passing locally now. Haven't tried them on 0.3 yet some adjustments might be necessary.

coveralls commented 9 years ago

Coverage increased (+4.0%) to 86.15% when pulling 6fc05ea5686d40f69a7de836189f3d6eb2b4b3ea on andreasnoack:master into 1b228ea098640835f28a0c1aebe2895ae19e0f62 on bokeh:master.

samuelcolvin commented 9 years ago

I don't have much time to concentrate on this project right now but from my point of view this all looks good. @andreasnoack are you happy for me to merge this? would you like another release to incorporate these changes and the others since v0.1.0?

andreasnoack commented 9 years ago

Yes. I think it is ready for merge and it would be great with a new release such that it works on master. I really like the Bokeh plots.