search

samuelcolvin / Bokeh.jl

Bokeh Bindings for Julia
Other
46 stars 14 forks source link

Fix JSON.jl _print deprecation #37

Closed TotalVerb closed 8 years ago

TotalVerb commented 8 years ago

JSON.lower has been introduced to replace JSON._print, whose overloads will be deprecated in JSON v0.7.0, and will be removed in the future. See https://github.com/JuliaLang/METADATA.jl/pull/5988 for the PR introducing the v0.7.0 tag. I would recommend not merging until the tag is actually merged (it's temporarily stalled because of plans to drop v0.3 support.)

bryevdv commented 8 years ago

Hi @TotalVerb thanks for the PR. Just FYI there is not currently an active maintainer for Bokeh.jl at the moment. If you are interested in Julia and Bokeh integration, and have the time and interest to contribute on a bigger scale the core Bokeh team would certainly be interested in helping you update Bokeh.jl to current releases. There is a world of difference between Bokeh 0.3 and current ~0.12.2 that is not available to Julia users right now.

sglyon commented 8 years ago

@bryevdv @TotalVerb I'm happy to review pull requests here, but don't have time to be the full maintainer and bring the project fully up to date with bokeh.js.

TotalVerb commented 8 years ago

Should be good to merge now.

sglyon commented 8 years ago

Thank you, will do!