Closed AngellusMortis closed 2 months ago
Merging #409 (6859e3e) into main (ab2dda2) will decrease coverage by
0.09%
. The diff coverage is93.75%
.
@AngellusMortis hi there 👋
I am taking advantage of your deeper knowledge regarding this hook.
question: without this PR the hook after_job_end
only works when there were no errors and jobs successfully finished?
E.g. if the job raised an exception, the hook won't be called ?
If that is the case, would there be a work around using other hooks ?
Thanks in advance
I no longer care.
Since
finish_job
can fail, I adjusted theafter_job_end
hook to always receive a copy of the theJobResult
that would get written into redis.I also updated all of the other places that recorded a failing job to call
after_job_end
as well and added aasyncio.shield
toafter_job_end
as it is a great way to do something with the job result (like generate metrics for New Relic/Prometheus/etc.).