search

samuelcolvin / jinjahtml-vscode

Syntax highlighting for jinja(2) html templates in vscode
https://marketplace.visualstudio.com/items?itemName=samuelcolvin.jinjahtml
MIT License
135 stars 53 forks source link

Yaml comments #116

Closed RedCMD closed 2 years ago

RedCMD commented 2 years ago

Fixes https://github.com/samuelcolvin/jinjahtml-vscode/issues/70

ctrl+/ toggles Yaml's comment #, instead of Jinja's block comment {# #} when Jinja Yaml is selected

I created a new language-configuration-yaml.json for Yaml

samuelcolvin commented 2 years ago

Interesting, but that's a big precedent to set - virtually all languages here have their own comments syntax which could arguably be the default.

If we do this, we should probably call this something generic so it can be used for python and other languages.

What do you think?

samuelcolvin commented 2 years ago

on balance, I think better to be consistent and use jinja comments everywhere.

If we do this we need to:

  1. make it configurable
  2. enable it for all languages supported

Let me know if you want that via an issue or start via a PR.