search

samuelcolvin / rtoml

A fast TOML library for python implemented in rust.
https://pypi.org/project/rtoml/
MIT License
323 stars 28 forks source link

Build amd64 wheels for windows #74

Closed Cranyozen closed 5 months ago

Cranyozen commented 11 months ago

This is a great project, I like it! It would be nice if the releases can contain amd64 wheels for windows too. Otherwise setuptools-rust must be present to continue the installation.

samuelcolvin commented 11 months ago

PR welcome to add it.

By the way, setuptools-rust isn't used, and maturin will be installed as a build requirement. The only external dependency is the rust toolchain.

zerocewl commented 10 months ago

maybe fixed with https://github.com/samuelcolvin/rtoml/pull/75 ?

the build wheels pipeline CI / build os is skipped, so i can't check which wheels are created

zerocewl commented 10 months ago

Seems to be fixed with #75, the pipeline contains now ...win_amd64.whl wheels again.

https://github.com/samuelcolvin/rtoml/actions/runs/7672121379/job/20911941988

  Compiling pyo3-build-config v0.20.0
   Compiling pyo3-ffi v0.20.0
   Compiling pyo3 v0.20.0
   Compiling rtoml v0.10.0 (D:\a\rtoml\rtoml)
    Finished release [optimized] target(s) in 14.90s
📦 Built wheel for CPython 3.11 to dist\rtoml-0.10.0-cp311-none-win_amd64.whl

Wheels should be part of the next release.

mirrorcoloured commented 8 months ago

Any updates on when this will be released? I'm stuck on a machine where I am unable to install rust.

LukasVik commented 8 months ago

I think it would be very good if there could be a new rtoml release made which includes the wheel for 64-bit Windows. I have started to get bug reports in https://github.com/hdl-registers/hdl-registers about pip install failing on Windows due to the dependency.

There are currently 322 projects on GitHub alone that use rtoml (https://github.com/samuelcolvin/rtoml/network/dependents). Releasing rtoml with Windows64 support reinstated would save a lot of confusion and bug reports.

mtessmer commented 7 months ago

I would like to second @LukasVik's request for another release to fix 64bit Windows installs. I am giving a tutorial on my package that depends on rtoml in a couple of weeks and it would be a lot better if my Windows users could install and update without issues or workarounds.

mtessmer commented 7 months ago

I also want to point out that there is no earlier version of rtoml for Python 3.12 on Windows. This means Python 3.12 users on Windows can't install rtoml without installing rust and Visual C build tools. This is likely a large hurdle for beginners and so all 322 packages that depend on rtoml are effectively broken for new users on Windows.

zerocewl commented 6 months ago

@samuelcolvin Can you please generate a new release? maybe a patch e.g. 0.10.1 is enough?

samuelcolvin commented 5 months ago

Turns out this is not as simple as triggering a release, due to https://github.com/PyO3/maturin/issues/2110. I think there's a workaround, see #79.

samuelcolvin commented 5 months ago

v0.11 is released, see https://pypi.org/project/rtoml/

LukasVik commented 4 months ago

Great, thank you so much @samuelcolvin!