samuelcolvin / watchfiles

Simple, modern and fast file watching and code reload in Python.
https://watchfiles.helpmanual.io
MIT License
1.79k stars 108 forks source link

Add support for Python 3.13 #277

Closed hugovk closed 3 months ago

hugovk commented 6 months ago

Helps https://github.com/samuelcolvin/watchfiles/issues/276.

Temporarily use PYO3_USE_ABI3_FORWARD_COMPATIBILITY: 1 until PyO3 supports Python 3.13.

Hopefully there will be a PyO3 0.21.3 soon so we can remove it:

https://github.com/PyO3/pyo3/issues/4038#issuecomment-2110007551

EwoutH commented 4 months ago

PyO3 0.22.0 and 0.22.1 are released with Python 3.13 support.

EwoutH commented 4 months ago

Opened a PR to update PyO3 to 0.22.1: https://github.com/samuelcolvin/watchfiles/pull/286

hugovk commented 4 months ago

The Python 3.13 release candidate is out now! :rocket:

We strongly encourage maintainers of third-party Python projects to prepare their projects for 3.13 compatibilities during this phase, and where necessary publish Python 3.13 wheels on PyPI to be ready for the final release of 3.13.0. Any binary wheels built against Python 3.13.0rc1 will work with future versions of Python 3.13. As always, report any issues to the Python bug tracker.

https://discuss.python.org/t/python-3-13-0-release-candidate-1-released/59703

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.51%. Comparing base (9f19a18) to head (1b36337). Report is 11 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #277 +/- ## ======================================= Coverage 99.51% 99.51% ======================================= Files 6 6 Lines 416 416 Branches 82 77 -5 ======================================= Hits 414 414 Misses 1 1 Partials 1 1 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/samuelcolvin/watchfiles/pull/277?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Samuel+Colvin). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Samuel+Colvin) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/samuelcolvin/watchfiles/pull/277?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Samuel+Colvin). Last update [8523610...1b36337](https://app.codecov.io/gh/samuelcolvin/watchfiles/pull/277?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Samuel+Colvin). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Samuel+Colvin).
EwoutH commented 4 months ago

@hugovk could you rebase this PR now that #287 is merged?

hugovk commented 4 months ago

Rebased!

samuelcolvin commented 3 months ago

Thanks so much.

@hugovk, since you're "here": thanks so much for Top PyPI Packages, it's really useful :pray:. Please could you update it for August.

hugovk commented 3 months ago

You're welcome!

Yeah, I need to sort out August, it's automated and failed to run on the 1st because it exceeded BigQuery quota. It (should be) using a dedicated key, so I'll probably need to reduce the total from 8k back towards the original 5k.

hugovk commented 3 months ago

PS thanks for watchfiles, it's a dependency of sphinx-autobuild which makes it much easier to work on Python docs. We have it enabled for CPython docs, the PEPs and devguide.