search

samuelcolvin / watchfiles

Simple, modern and fast file watching and code reload in Python.
https://watchfiles.helpmanual.io
MIT License
1.79k stars 108 forks source link

Bump up PyO3 to 0.22.2 #287

Closed FlickerSoul closed 4 months ago

FlickerSoul commented 4 months ago

This PR bumps PyO3 to 0.22.2 to support Python 3.13. Note that because PyO3 is still working on free-threaded Python 3.13, the build only works on 3.13 with GIL.

Related to #276, #286, and #277

EwoutH commented 4 months ago

Thanks a lot!

@samuelcolvin would you be able to review and merge this PR, and tag a new release?

FriedrichFroebel commented 4 months ago

Why does this PR delete the Cargo.lock file? It tends to be useful for different cases, for example to determine the package versions known to work and to know the versions used for building a release.

FlickerSoul commented 4 months ago

Hi @FriedrichFroebel! The Cargo.lock is not deleted. The changes are just folded by GitHub. If you click the Load Diff, you can see the diff caused by updating the dependencies. :)

EwoutH commented 4 months ago

samuelcolvin would you be able to review and merge this PR, and tag a new release?

Sorry, to be a bit assertive @samuelcolvin, but could you give a timeline when you will be able to review and merge this PR? @FlickerSoul clearly put an effort in, and there are downstream dependencies waiting on this PR to be merged and a new release to be tagged.

It’s okay if it takes a while because whatever reason, but please communicate with us.

EwoutH commented 4 months ago

Python 3.13 is now in it's release candidate phase and packages need to be uploaded to PyPI.

@samuelcolvin, could you give any sign of life?

samuelcolvin commented 4 months ago

Merged, sorry for the delay, I'll try to make a release tomorrow.

samuelcolvin commented 4 months ago

Thanks so much for the contribution @FlickerSoul.

EwoutH commented 4 months ago

Thanks for getting back!

Could you also include https://github.com/samuelcolvin/watchfiles/pull/277 in the next release?