search

samuelcolvin / xdelta3-python

Fast delta encoding in python using xdelta3
Other
34 stars 15 forks source link

change byte lengths to use Py_ssize_t #11

Open jacobfeder opened 2 years ago

jacobfeder commented 2 years ago

This will solve some deprecation warning messages in more recent python versions.

samuelcolvin commented 2 years ago

LGTM, could you also update the readme.

github actions will also need to be added and travis removed before I can release a new version. Might not be until september.

jacobfeder commented 2 years ago

Ok no problem. Thanks!

jacobfeder commented 2 years ago

@samuelcolvin this deprecation warning is now an error in python 3.10 and prevents usage of the library - please let me know if there's anything I can do to to help get this change made. I'd be happy to take over maintenance if you'd like.

Thanks

samuelcolvin commented 2 years ago

I'll try to fix it next week.

On Sun, 26 Dec 2021, 20:40 Jacob Feder, @.***> wrote:

@samuelcolvin https://github.com/samuelcolvin this deprecation warning is now an error in python 3.10 and prevents usage of the library - please let me know if there's anything I can do to to help get this change made. I'd be happy to take over maintenance if you'd like.

Thanks

— Reply to this email directly, view it on GitHub https://github.com/samuelcolvin/xdelta3-python/pull/11#issuecomment-1001239546, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA62GGNOPCQOP7BQ4IGFICLUS54VHANCNFSM5BEVB2TQ . You are receiving this because you were mentioned.Message ID: @.***>

vadimszzz commented 2 years ago

I'll try to fix it next week. …

Thanks. Waiting for you.

jacobfeder commented 2 years ago

I'll try to fix it next week. … On Sun, 26 Dec 2021, 20:40 Jacob Feder, @.> wrote: @samuelcolvin https://github.com/samuelcolvin this deprecation warning is now an error in python 3.10 and prevents usage of the library - please let me know if there's anything I can do to to help get this change made. I'd be happy to take over maintenance if you'd like. Thanks — Reply to this email directly, view it on GitHub <#11 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA62GGNOPCQOP7BQ4IGFICLUS54VHANCNFSM5BEVB2TQ . You are receiving this because you were mentioned.Message ID: @.>

Hi @samuelcolvin - bump on this. If you give repo access I'd also be happy to implement the travis/GH changes you had mentioned if you give me instructions on how you'd like it.

Best, Jacob