search

samuelcolvin / xdelta3-python

Fast delta encoding in python using xdelta3
Other
34 stars 15 forks source link

fix for large decoded value #3

Open samuelcolvin opened 6 years ago

samuelcolvin commented 6 years ago

fix #2

codecov[bot] commented 6 years ago

Codecov Report

Merging #3 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master     #3   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      2    -1     
  Lines          44     42    -2     
=====================================
- Hits           44     42    -2
mwojnars commented 4 years ago

Hi! Have you pushed this change to PyPI ? I installed xdelta3 from there and it still produces an error. I checked the installed files and _xdelta3.c contains old version of code, from before the fix.

Example strings that reproduce the error:

a = b'wonderful string to demonstrate xdelta3, much of these two strings is the same.' b = b'diff string to demonstrate xdelta3, 888888888888888888888888888888888888888888888888888888888888 much of these two strings is the same.'

BTW, in this example, delta is very short despite many 8's inserted. Do you detect repetitions and compress them somehow, in addition to making plain diff comparison?

samuelcolvin commented 4 years ago

This isn't on pypi

BTW, in this example, delta is very short despite many 8's inserted. Do you detect repetitions and compress them somehow, in addition to making plain diff comparison?

This repo is just a wrapper around xdelta, have a look there for details on how the delta encoding works.