search

samuelduchesne / archetypal

archetypal: Retrieve, construct, simulate, convert and analyse building simulation templates
https://archetypal.readthedocs.io/
MIT License
11 stars 8 forks source link

DHW to_epbunch #450

Closed zlehong closed 1 year ago

zlehong commented 1 year ago

Added to_epbunch function to DHW template for end-use calculations.

samuelduchesne commented 1 year ago

@zlehong see how this PR pulls from your zlehong:main branch? It includes the history of commits. We would want to keep those separate such that the PR only contains the changes related to this PR.

One way to keep things clean is to checkout the main branch and pull the latest changes. Then create a new branch, let’s call it feature/dhw. Then commit changes, push to zlehong:feature/dhw and create a PR from zlehong:feature/dhw to samuelduchesne:main

samuelduchesne commented 1 year ago

closing since implemented in #458