samueleaton / sentry

Build/Runs your crystal application, watches files, and rebuilds/restarts app on file changes
MIT License
286 stars 27 forks source link

Error: undefined method 'mapping' for YAML:Module #59

Open szabgab opened 3 years ago

szabgab commented 3 years ago

This is my code for now:

$ cat src/sentry.cr 
require "sentry"

This is the error I get:

$ crystal run src/sentry.cr 
Showing last frame. Use --error-trace for full trace.

In lib/sentry/src/sentry.cr:12:10

 12 | YAML.mapping(
           ^------
Error: undefined method 'mapping' for YAML:Module

This is Crystal:

$ crystal --version

Crystal 1.0.0 [dd40a2442] (2021-03-22)

LLVM: 10.0.0
Default target: x86_64-unknown-linux-gnu

Running on Ubuntu 21.04

straight-shoota commented 3 years ago

The sentry version you're using is not compatible with Crystal 1.0.

It looks like this should be fixed in the master branch, but there has not been a sentry release in over a year.

szabgab commented 3 years ago

:+1:

samueleaton commented 3 years ago

works for me on latest crystal version. is this just me needing to republish a new release? Just did a new release.

straight-shoota commented 3 years ago

Yes, that should fix it. The updated code was just not released yet.

szabgab commented 3 years ago

Thanks, it works now.

There is one more thing though, The shards.yml file has crystal: 0.34.0 which means we need to use --ignore-crystal-version I think it would be better to have crystal: >= 0.34.0