search

samueleishion / gulp-axe-cli

Gulp plugin to test static pages with aXe as pre-commit hook or in CI environment.
MIT License
2 stars 1 forks source link

Why use axe-cli and not axe-core or axe-webdriverjs ? #7

Open ryuran opened 6 years ago

ryuran commented 6 years ago

Hello.

The question in the title.

samueleishion commented 6 years ago

hello! axe-webdriverjs was giving me errors when spinning up selenium. There was another issue i can't recall when running axe-core. I do want to revisit the use of axe-cli vs axe-core before releasing 1.0.0. I'll actually add a branch to start exploring the change to axe-core. Thanks!

samueleishion commented 6 years ago

Here's the branch: feat/#7-use-axe-core I'll be adding this issue number to the comments if you want to stay in the loop. Feel free to contribute 😁

ryuran commented 6 years ago

I will try to help.

samueleishion commented 4 years ago

hey @ryuran as i've been doing more research and testing, i've been really looking into the pros and cons of using axe-cli vs axe-webdriverjs. lately, i've been looking into node's child_process and .spawn() and its benefits: https://nodejs.org/api/child_process.html#child_process_child_process_spawn_command_args_options https://www.freecodecamp.org/news/node-js-child-processes-everything-you-need-to-know-e69498fe970a/#spawned-child-processes

I do like the fact that .spawn() spins up a process separately from the current one running node, going around the single-threaded nature of node. I know this might seem counter-intuitive due to the fact that i'm using spawnSync, but in the CI/CD context I'm trying to use this library, it made sense to me, but i'll be researching more into pros and cons of going sync vs async. This could be a simple change, though. To be fair, I haven't done benchmark testing, but this library could be used to run benchmark test in contrast to gulp-axe-webdriver or any other node-based webdriver library.

BTW, I just released version 1.0.0. Feel free to check it out and provide any feedback. I'll be doing more research and looking more into whether this library is performant enough or not, but so far, it's proving useful in other CI/CD projects that are consuming this.

MPParsley commented 1 year ago

https://www.npmjs.com/package/axe-cli is now deprecated.