Plans with update/sharing themes

[Klap-in]

Hi @samuelet

At the admin page there is a tool for checking updates (the endpoint http://samuele.netsons.org/dokuwiki/lib/plugins/indexmenu/remote.php?check=$date is not available anymore) and sharing themes has issues. I observe that for uploading there is also a manual form at your site.

Do you still receive themes via this infrastructure?

My proposal is to remove the following code: https://github.com/samuelet/indexmenu/blob/master/admin.php https://github.com/samuelet/indexmenu/blob/master/inc/pclzip.lib.php https://github.com/samuelet/indexmenu/blob/master/inc/repo.class.php https://github.com/samuelet/indexmenu/blob/master/ajax.php (all local communication is already moved to action.php using the _ajax_call)

My impression is that this infrastructure is not used. Further in the 2020 release of DokuWiki things are changed, which needs action.

admin.php could be replaced by a reference and explainer how someone can share themes. For example uploading it directly to github. Maybe easier to move this explaination completely to https://www.dokuwiki.org/plugin:indexmenu

[samuelet]

Provider php updates had broken my unmaintained site. I managed to restore it and now the functionalities seems to work again. I've some themes to uload in this github repository, however i understand the issue. The new version check functionality can be removed (require unuseful extra work to mantain the related changelog file and i guess it's superseded by the plugin info txt) . The same for the theme uploading, i agree to display the info to open a github issue or even, for users without github account, to send directly via mail to me. What i'm in doubt to remove is the web way to view and install new themes ( no needs of ftp/ssh account, motivate user to contribute etc ..) but i've no stats to support it. Moreover, i think that the current code to retrieve themes must be changed to get data from this github repository instead of from my "unreliable" site. In order to understand the implications to mantain the existing view and install code, could you point me out where i can find plugin changes required for the new Dokuwiki release ( i know about defer js) ?

[Klap-in]

I have been trying already a bit in the mean time. Probably a number of changes are easy e.g. HTTPClient. I hope to share these changes next week. I think defer js is the feature that is due to the new DokuWiki release. But some older bits are creating issues too.

I'm using intellij IDEA, which suggest already a lot of deprecated bits. (if you are only doing open source coding, intellij IDEA is available for free).

At the moment the images are quite small. (at the moment the image folder has a size of 0.5 MB, including a duplicated set of zips). So my impression is now that a separate download location for the themes is not needed (e.g. to improve download size of the plugin). If all themes that users share are included in the repository at github, these themes are automatically downloaded if people update the indexmenu plugin. Indeed to add own images locally, a local interface at the admin page can be helpful.

I think that would mean the following steps:

• [ ] at wiki page explain people can contribute themes via github or email
• [x] if theme is received the theme is added to indexmenu/images/ folder in the github repository.
• [x] all indexmenu plugins get automatically the new themes if updated
• [ ] at admin page add an interface for easy creating a new theme and adding images in the local /indexmenu/images/ folder, and downloading it again for sharing
• [ ] not used parts can be removed (e.g. pclzip.lib.php, repo.class.php, ajax.php and part of admin.php)

Do you agree? do I miss features?

[Klap-in]

At this page you can find a more detailed list of changes. https://www.dokuwiki.org/devel:releases However the changes due to the refactoring are not yet included.

[samuelet]

it's ok for me