Javascript refactor

[Klap-in]

Refactor the javascript code:

• [ ] use only deferred loading, so remove all inline code that needs direct execution. (removal of old code if new code is tested enough, so first an period with both old and new tree.
• [x] consider retrieving node-data with data attribute or ajax.
• [x] Implement FancyTree (https://wwwendt.de/tech/fancytree/demo/index.html) instead of old dTree treemenu.
• [x] Reconsider all the javascript options
• [ ] clean up contextmenu
• [x] Clean up php code (requires/old json functions/etc)

Implementing new menutree with FancyTree:

• [x] Proposal: add temporary treenew, treeold and treeboth option. (First to test both, if stable, swap to default treenew In e.g. after one year these options are removed.)
• [x] add urls to nodes for pages and for headpages if a namespace
• [x] allow more js-trees on one page (only if not unique)
• [x] ajax loading of all node data (per level)
• [x] js option: max#n[#m] (number of levels retrieved by AJAX at initial loading #n and lazy loading #m). Max on initial loading (probably) only applied if navbar option was used. Proposal: keep option, #n default 1, #m also default 1. (level set number of opened levels, overrules this setting of course)
• [x] #245
• [x] option: navbar (tree opens itself in current namespace)
• [x] option: nons (exclude ns nodes)
• [x] option: nopg (exclude page nodes)
• [ ] #244
• [ ] #246
• [x] js option: noscroll (lets tree menu scroll in small widths) Proposal: remove
• [x] js option: id#[random|ns|number] (used for storing opened/closed nodes) Proposal: remove
• [x] js option: cookie (stores opened/closed nodes). Proposal: remove
• [x] js option: maxjs#n (number of nodes rendered) Proposal: remove (not needed with todays javascript/not supported by Fancytree)

To check:

• [x] useslash https://www.dokuwiki.org/config:useslash, need of idfilter() (for :,;,/)
• [x] rewrite settings, https://www.dokuwiki.org/config:userewrite e.g. specific links layout needed?
  • url building in js uses already DOKU_BASE

[Klap-in]

Fancytree

I started the first work on replacing dTree by FancyTree. First results:

[Klap-in]

Contextmenu

I wonder if I should readd the contextmenu again, but my impression is that there is a smaller group, that really appreciates this functionality.

Please see #244 for detailed discussion whether the contextmenu should return.

Please share your preference: :+1: = keep the contextmenu feature, :-1: = I do not use the contextmenu feature

[vmario89]

indexmenu plugin is still the best plugin to display menu at the sidebar. Now i recognized, using the ckgedit editor we have to decide for defer_js or against defer_js option. the indexmenu requires to disable it, the ckgedit requires to enable it :-O i am not skilled enough to add the required changes to indexmenu to make it work with the defer_js option. seens there is no more progress yet by anyone. did not find any pull requets or forks :O

[Klap-in]

I started with implementing the Fancytree javascript tree. But I need to perform a large refactoring of the code as well. Because it is still quite broken, I did not publish it yet.

[Klap-in]

First version of the new js tree based on Fancytree is available: #254

Temporary extra settings: treenew, treeold and treeboth.

Any feedback is welcome. Please note it is still subject of change.

Not yet tested with the following settings, if you use these, please share your experience:

• useslash https://www.dokuwiki.org/config:useslash
• rewrite settings, https://www.dokuwiki.org/config:userewrite e.g. is there still a specific links layout needed?

[jakob11git]

Just one thing I noticed when using the deferjs branch: Icons do not load because I have DokuWiki in a subdirectory. I manually amended the all.less file on line 13 to add my subfolder before the prefix and then it seems to work.

Oh and another: The URLs to click on didn't work for me because they didn't include doku.php?id= which is needed in our wiki. I went to script.js and added that manually in the the function for enhanceTitle property of fancytree object, but this would probably need to get auto-detected somehow.

I also removed the warning about using the js option while having defer_js enabled. In our internal wiki we just have a single page with a simple indexmenu showing all pages, so I'm satisfied.

[Klap-in]

Thanks for your feedback! It confirms that the different urls due to the different rewrite settings still needs more coding and testing. If I have an update I would like to ask you for new feedback.

[Klap-in]

I expect I have a rather okay state of the plugin again. The treenew is not feature complete, and is a bit different that the dTree based one. Therefore, I do not make it default yet.

Everybody who like to try is invited to do so! Any feedback is welcome. If this is stable enough, I will release it for everybody on short notice.

@jayna37 I think I have solved your issues for your case where you do not use urlrewriting. You are welcome to test.

[Klap-in]

Please see #269 for the latest version of the development version. You can also download it from the devel branch (https://github.com/samuelet/indexmenu/archive/devel.zip)

[jakob11git]

@Klap-in Sorry, but I left that company in the meanwhile. Would've been happy to test for you with that specific installation.

[Klap-in]

• [x] I have now implemented a Fancytree based Javascript tree. Also I marked the old dTree based tree as deprecated. The old tree is still the default.
• [x] If I think details of the Fanytree based tree are also sorted out I will promote it a bit more, to ensure more people will test it.
• [ ] If it seems used enough, I will change the defaults, such that everybody uses automatically the new tree.
• [ ] If not too much issues appear, and people are common to the new tree, I will remove the old tree. For if anybody needs it, older versions from before above milestones will be stored in the Release section.

I will remove the old JavaScript tree because its maintenance is too much work. It is not doable to keep it.

I guess now that most remaining issues/questions will be related to the new skins.

[rgleason]

I find that our index menu is no longer working properly, and it has performed flawlessly for years. No indexmenu is unresponsive when I remove a page, or change the title. What has happened here? https://opencpn.org/wiki/dokuwiki/doku.php?id=opencpn:supplementary_software:signalk:sk-windows

https://opencpn.org/wiki/dokuwiki/doku.php?id=opencpn:supplementary_software:signalk:a1