samuelet / indexmenu

A dokuwiki plugin to show a customizable and sortable index for a namespace.
http://dokuwiki.org/plugin:indexmenu
GNU General Public License v2.0
44 stars 43 forks source link

deprecated Function in IGOR #256

Closed LMS235 closed 2 years ago

LMS235 commented 2 years ago

After update to IGOR:

JSON::encode() is deprecated. It was called from syntax_plugin_indexmenu_indexmenu::_jsnodes() in /wiki/lib/plugins/indexmenu/syntax/indexmenu.php:549 json_encode should be used instead!

Klap-in commented 2 years ago

To be sure, that is with the latest version of the Indexmenu?

Klap-in commented 2 years ago

Ah, I found it already. I will change it, probably this evening.

Klap-in commented 2 years ago

Fixed in e6134db4b6cabc1904473be056d4b50c30566bf2

ParoTheParrot commented 1 year ago

@Klap-in : by closing this issue, is indexmenu compatible to Igor? In this case, please update https://www.dokuwiki.org/plugin:indexmenu. TIA, Paro!

Klap-in commented 1 year ago

In Hogfather and Igor you have to set an feature flag: https://www.dokuwiki.org/plugin:indexmenu

To improve that I’m implementing https://github.com/samuelet/indexmenu/issues/230 That is a bit slow process. In general php7 will work fine, I saw already some details related to php8 which could maybe cause issues.