search

samuelet / indexmenu

A dokuwiki plugin to show a customizable and sortable index for a namespace.
http://dokuwiki.org/plugin:indexmenu
GNU General Public License v2.0
47 stars 43 forks source link

Update syntax\indexmenu.php to use sexplode #264

Closed eduardomozart closed 1 year ago

eduardomozart commented 1 year ago

Sexplode is a new function available on DokuWiki "Igor" (Dev Branch) that allows to split lists into a safe way. PHP 8.1 and Indexmenu was throwing an error on search page results on exploding without it when the user attempts to search when on Wiki home page (wiki.example.com/doku.php?id=start).

Klap-in commented 1 year ago

Thanks for the proposal. Problem is that this function is not backward compatible (there are still many Hogfather users), so I prefer at the moment the array_pad approach.

eduardomozart commented 1 year ago

I see. No problem. I'd updated my PR so now it uses sexplode only if available. Tested the array_pad function on DokuWiki Igor and seems to be working as expected. Please also see the PR #261 (specially my comment there), as IndexMenu doesn't work with PHP 8+ without it.