search

samuelet / indexmenu

A dokuwiki plugin to show a customizable and sortable index for a namespace.
http://dokuwiki.org/plugin:indexmenu
GNU General Public License v2.0
44 stars 42 forks source link

Attempts to restore Hogfather compatibility #294

Open eduardomozart opened 5 months ago

eduardomozart commented 5 months ago

The class PageResolver doesn't exists on DokuWiki Hogfather and older releases, so this PR attempts to fix https://github.com/samuelet/indexmenu/issues/291 by falling back to the old function "resolve_id" to parse NS if the class PageResolver isn't available.

Klap-in commented 5 months ago

There are also a lot of changes, e.g. by using php7.4 functionalities, that break compatibility with old DokuWiki releases. Is it worth to add these kind of things back? Better people update there DokuWiki in time, such that the updates remain relatively smaller… and hopefully easier.

eduardomozart commented 5 months ago

There are also a lot of changes, e.g. by using php7.4 functionalities, that break compatibility with old DokuWiki releases. Is it worth to add these kind of things back? Better people update there DokuWiki in time, such that the updates remain relatively smaller… and hopefully easier.

I agree. I didn't want to support those legacy DokuWiki versions neither, but I believe this is the only func that breaks compatibility with older DokuWiki releases, so users that doesn't have DokuWiki control can still keep IndexMenu updated.