samuelfangjw / pe

0 stars 0 forks source link

Wrong error message when a large positive index is given #3

Open samuelfangjw opened 3 years ago

samuelfangjw commented 3 years ago

Screenshot 2021-04-16 at 2.31.19 PM.png

Error message when large positive index is given says invalid command format. However, the command edit 100000000000000 q/10 e/2022-10-11 follows the format given as the index is still a large positive number. The error message should instead let the user know that the index is invalid.

Low severity as user is unlikely to input such a large index, but it might still be confusing if a user accidentally enters the wrong index.

nus-pe-bot commented 3 years ago

Team's Response

Thank you for pointing it out. This was actually a bug that was inherited from AB3 that we failed to rectify.

Severity: We are labelling this as VeryLow because it is a very very rare occurrence where users key in an exceptionally large invalid index, and it does not cause any inconvenience for the users.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: I disagree with the teams assessment of the severity.

From the module website a VeryLow severity bug is a flaw that is purely cosmetic and does not affect usage e.g., a typo/spacing/layout/color/font issues in the docs or the UI that doesn't affect usage.In this case, it is not purely cosmetic (might affect usage since users might think their command format is wrong).

That being said, I do agree that it is a rare occurrence. That is why a low severity is more appropriate. From the module website, low severity issues are A flaw that is unlikely to affect normal operations of the product. Appears only in very rare situations and causes a minor inconvenience only. In this case, the bug is rare, the flaw is unlikely to affect normal operations of the product and at worse causes minor inconvenience to the user.

note: inherited from AB3 is no longer a valid reason to reject bugs, as seen in the screenshot below. Screenshot 2021-04-20 at 1.01.43 PM.png