samuelfangjw / pe

0 stars 0 forks source link

Find command unintuitive #4

Open samuelfangjw opened 3 years ago

samuelfangjw commented 3 years ago

Steps to replicate

Screenshot 2021-04-16 at 2.41.52 PM.png

Find an item in the list, in this case using find Beer, note that hehe is the first item in the list.

Screenshot 2021-04-16 at 2.42.50 PM.png

Use find to find another item, in this case find hehe.

Screenshot 2021-04-16 at 2.43.11 PM.png

Unable to find the item.

Update: Whilst i found a reference in the UG to this issue, I still feel the find command is unintuitive and does not work as expected, hence the feature flaw.

For example, I want to find some milk in the fridge but i am unsure what type of milk i have.

i type list l/fridge to list all items in fridge and then type find marigold and do not see any results, then i would naturally type find otherbrand to try to find my milk but this would not show me the desired result. I would be inconvenienced and have to do list l/fridge again.

nus-pe-bot commented 3 years ago

Team's Response

General response: This is a design choice made by the team, we cannot differentiate when will the users wish to filter from the whole list or the currently displayed list. We felt that in most situations, filtering on the currently displayed list will be more useful/helpful for users, and hence the design decision. Thank you for your suggestion though.

Severity: We are labelling this as Low because users (especially for fast-typists) can get the full inventory by typing 4 letter word 'list'. This will not cause many inconveniences for the users.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thank you for your response. However, I disagree with the rejection.

The team mentioned their design decision to filter based on the current list, as it will be more helpful for users. However, as shown in my issue, this may not be the best decision (hence the feature flaw) since it unnecessarily inconveniences users who want to search for multiple items. For example, if i type find ABC and want to find DEF right after, I would have to reset the currently displayed list, which inconveniences the user.

The also team mentioned that we cannot differentiate when will the users wish to filter from the whole list or the currently displayed list. However, off the top of my head I can think of many ways to solve this issue. For example, a user could add tags to indicate which list why would like to filter from, or find could work on the main list and the UI display find results by category, or the find command could work on the currently selected filter (e.g. if list is filtered by location kitchen, find always works on the whole kitchen).

The team mentioned that they chose to find from the currently selected list as this will be more helpful to the user. However, I cannot think of many situations where this will be more helpful compared to the solutions I have suggested above. For example, one could argue that a user might use the find command and want to narrow down his search options after, but this is a rare occurrence, and can also be handled nicely using the other methods without inconveniencing the user.


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]