samuelfangjw / pe

0 stars 0 forks source link

Expiry date not shown in orange if item is expiring on same day #6

Open samuelfangjw opened 3 years ago

samuelfangjw commented 3 years ago

Screenshot 2021-04-16 at 2.53.37 PM.png

In the screenshot, item 3 expires today 16 apr but is coloured red instead of orange.

Screenshot 2021-04-16 at 2.54.47 PM.png

From the UG, expiry date should be orange instead.

nus-pe-bot commented 3 years ago

Team's Response

Thank you for pointing it out.

Severity: This is a cosmetic issue, thus we are changing the severity to VeryLow since functionality is not affected.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: Thank you for your response, however I disagree with the severity of the issue.

As stated in the module website, very low severity refers to A flaw that is purely cosmetic and does not affect usage e.g., a typo/spacing/layout/color/font issues in the docs or the UI that doesn't affect usage.

In this case, while it is a cosmetic bug, it is not a purely cosmetic bug. As stated in your UG, the colours of the text mean different things, red = expired, orange = expiring. This makes it not a purely cosmetic bug.

Screenshot 2021-04-20 at 12.36.54 PM.png

This feature also affects usage, since users will look at the item and think it is expired. Hence, this bug does not fit the definition of very low severity.

I instead believe this should be Medium severity, whose definition from the module website is as follows : A flaw that causes occasional inconvenience to some users but they can continue to use the product.

To me, this is akin to having a text field that tells the user whether an item is expired, expiring or not expiring, and labelling it expired when in fact it should be expiring, because users would rely on the colours to tell if an item is expired or not.

In my case as a tester, I was specifically looking to see if the dates matched up, that's why I was able to catch this bug. However, I believe real users will easily miss this, since as a user I would not (and should not have to) bother to check the date once I notice the text is red (especially since it's only 1 day difference it's quite plausible the item is already expired). For example, if I have bread that is about to expire and I see the text is red, it's quite unlikely that I will go check the date to make sure the item has not expired yet since I know it has been about a week since I bought it and its about to expire. I'll just throw it away. Hence, this causes occasional inconvenience to some users.

In addition, I believe this bug is actually quite a common occurrence, since it occurs when an item is about to expire on the day itself. In an app built to keep track of expiry dates, a user will come across this bug quite frequently (every-time an item has 1 day left before it expires). So we cannot say this is a rare occurrence (rare would make this a low severity bug).

Hence, because of the reasons stated above, I believe this should be a medium severity bug.