samueljuma / Upcoming-Movies

Project 5: Android Kotlin Developer Udacity | Nanodegree
1 stars 0 forks source link

Research & implement | Add git branch protection rules #4

Open RocqJones opened 1 month ago

RocqJones commented 1 month ago
samueljuma commented 1 month ago

I applied protection to the main branch

It looks to me like all rules are enforceable anyway. Is there a set of the "classic ones" for simplicity?

RocqJones commented 1 month ago

I applied protection to the main branch

  • [x] Require a pull request before merging

    • [x] Require approvals
    • [x] Dismiss stale pull request approvals when new commits are pushed
    • [x] Require review from Code Owners
    • [x] Require approval of the most recent reviewable push
  • [x] Require conversation resolution before merging
  • [x] Require linear history
  • [x] Lock branch

It looks to me like all rules are enforceable anyway. Is there a set of the "classic ones" for simplicity?

Remove 'Lock Branch' you won't be able to do a merge into the main branch

samueljuma commented 1 month ago

I applied protection to the main branch

  • [x] Require a pull request before merging

    • [x] Require approvals
    • [x] Dismiss stale pull request approvals when new commits are pushed
    • [x] Require review from Code Owners
    • [x] Require approval of the most recent reviewable push
  • [x] Require conversation resolution before merging
  • [x] Require linear history
  • [x] Lock branch

It looks to me like all rules are enforceable anyway. Is there a set of the "classic ones" for simplicity?

Remove 'Lock Branch' you won't be able to do a merge into the main branch

Got it