search

samueljun / tomato-clock

Tomato Clock is a simple browser extension for managing your productivity.
GNU General Public License v3.0
329 stars 54 forks source link

Stat is not reporting #82

Closed Sunnygtiff closed 3 years ago

Sunnygtiff commented 4 years ago

Describe the bug It's not counting what I did at all today!

To Reproduce It did not track any breaks nor tomatoes.

Expected behavior It should track it

Desktop (please complete the following information):

kaijurgeit commented 3 years ago

Same here. In my case records not working for firefox anymore (yesterday they did). In chrome however, records are working.

Desktop:

Sunnygtiff commented 3 years ago

It was working in Chrome for a couple of weeks then it stopped working.

On Thu, Jul 30, 2020, 8:53 PM Kai Jurgeit notifications@github.com wrote:

Same here. In my case records not working for firefox anymore (yesterday they did). In chrome however, records are working.

Desktop (please complete the following information):

  • OS: Window 10
  • Browser Firefox
  • Version 79.0 (64bit)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/samueljun/tomato-clock/issues/82#issuecomment-666345807, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQBZ47YIO5YAYKOFITORUQ3R6FUL5ANCNFSM4OGCX5ZQ .

kaijurgeit commented 3 years ago

In my case it stopped working today when using firefox. I just installed it in chrome where it worked fine. But Firefox is my default Browser.

AlyssonR commented 3 years ago

Same here. Stopped working today. (Firefox 79.0 in Ubuntu).

samueljun commented 3 years ago

Hey folks, thanks for the bug reports. Could someone do the following to help me debug the issue?

  1. Complete a Tomato
  2. Go to Stats
  3. Confirm that the Tomato didn't tracked
  4. "Export Stats as JSON" and attach it here?

The stats file will help me at least confirm if the issue is the underlying data tracking or with a rendering bug on the Stats page.

Sunnygtiff commented 3 years ago

Window 10 Chrome Tomato Clock 5.2.0

On Sun, Aug 2, 2020 at 11:22 PM Samuel Jun notifications@github.com wrote:

Hey folks, thanks for the bug reports. Could someone do the following to help me debug the issue?

  1. Complete a Tomato
  2. Go to Stats
  3. Confirm that the Tomato didn't tracked
  4. "Export Stats as JSON" and attach it here?

The stats file will help me at least confirm if the issue is the underlying data tracking or with a rendering bug on the Stats page.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/samueljun/tomato-clock/issues/82#issuecomment-667687386, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQBZ47YNMMRHR3QIDABK4CLR6WADFANCNFSM4OGCX5ZQ .

kaijurgeit commented 3 years ago

I can confirm, it did not record the tomato I just finished. It's not a rendering bug, it's not written to the json-file. See attachement.

tomato-clock-stats.zip

mishasan commented 3 years ago

Hey, same here

Windows 10 Firefox (79.0 64Bit) Tomato Clock 5.2.0

See my JSON Export from just now (2020_08-03) after tracking 2 tomatoes and 2 short breaks: [{"date":"2019-06-13T13:00:08.000Z","timeout":1500000,"type":"tomato"},

.... MORE DATA ...

{"date":"2019-12-17T09:11:57.000Z","timeout":1500000,"type":"tomato"},{"date":"2019-12-17T14:22:30.000Z","timeout":300000,"type":"shortBreak"},{"date":"2019-12-17T14:53:34.000Z","timeout":1500000,"type":"tomato"},{"date":"2020-01-31T13:27:48.000Z","timeout":300000,"type":"shortBreak"}]

To me, it seems that it does not track data anymore (have not been using it a while, so I can't tell when it stopped). The diagram view is okay: If I change the range to the last year it displays the graph from December 2019 as in my JSON from above. Hope that helps. Greetings.

whym commented 3 years ago

I experienced the same issue with Firefox 79.0 on Ubuntu. I tried a couple of things (after exporting the data) :

At least for Firefox, the last point might be related to: https://blog.mozilla.org/addons/2020/07/09/changes-to-storage-sync-in-firefox-79/ (well, I'm not really sure, but the timing looks suspicious.)

kaijurgeit commented 3 years ago

@whym Resetting the stats helped me too. Thank you! And thanks to the author of this plugin, which helps me a lot to stay focussed in the home office these days . :)

samueljun commented 3 years ago

Thanks for the link and console.log @whym! Also based on all the reports here, it sounds a lot like the issue is with the storage size limits.

I originally set the stats data to be stored on storage.sync so that the stats could be synced across all devices. However the size limits there are clearly too small for typical usage. Since the sync storage is clearly too small, I'm going to switch to storage.local as a first step. The limit there is much larger at 5 MB (~500x bigger). The caveat here is that the stats will only be stored on the local browser and won't be synced across all of your browsers anymore.

I'm not sure if folks found a lot of value in the stats being synced. If you did, I would say to follow up with a feature request for an option to use sync storage. And I could look at putting in an option allowing you to pick which storage you want, with disclaimers on the file size limits.

samueljun commented 3 years ago

6.0.0 has been released with the fix, feel free to reopen if you're still seeing the issue!

whym commented 3 years ago

I just wanted to note that (expectedly) the issue didn't reappear after the update so far. Thank you for the great work!