Open samuelmaddock opened 3 years ago
Is there any news on electron's support for injecting JS into service worker contexts?
https://developer.chrome.com/docs/extensions/mv3/mv2-sunset/
Here's the V2 support timeline, and so we're looking to get upgraded to V3 before V2 is completely killed off.
Is there any news on electron's support for injecting JS into service worker contexts?
Currently no update. I've spent time researching what it would take and the amount of work is non-trivial.
Electron's preload scripts work in a secure environment thanks to the effort of extension content scripts which provide an isolated JS context. Node's globals and other variables within preload scripts are separate from the main JS context. This is how V8's binding system works: https://chromium.googlesource.com/chromium/src/+/master/third_party/blink/renderer/bindings/core/v8/V8BindingDesign.md#world
The problem is when trying to do the same thing with Workers (Service, Web, Shared). Support for isolated worlds/contexts within a worker environment isn't something that exists yet. This has been attempted before without context isolation which isn't a secure approach (see https://github.com/electron/electron/pull/28923#issuecomment-834671017).
At a high-level, here's a list of what might be needed:
v8::Context
in the renderer's Worker Thread to run alongside global service worker contextscontextBridge
API to provide a bridge between the worker preload context and the service worker contextworker.executeScript(js)
Then there's a few other requirements just for API design within Electron. A design proposal might be needed for that in the API governance repo.
I do realize the importance of this work prior to Chrome dropping support of MV2, however, I don't currently have a roadmap for these contributions.
@samuelmaddock hello. May I know the current status of this matter? Is there any news on electron's support for injecting JS into service worker contexts?
i am using electron-chrome-extensions
but it only supports V2.
Electron does not yet support preload scripts for service workers. I'm not aware of others currently working towards adding this.
I spent time on it a couple of months ago, but I have no estimate and I'm not close to a solution.
In case anyone is interested, there is movement towards Manifest v3; https://github.com/electron/electron/pull/39395
any updates on this :(
I'm currently awaiting comments on my RFC which would unblock this https://github.com/electron/rfcs/pull/4
Hello, @samuelmaddock Are there any updates on this? And is it difficult for Electron to support preload scripts for service workers? If it did, it would be a cool thing.
Hello, @samuelmaddock
Are there any updates on this?
And is it difficult for Electron to support preload scripts for service workers? If it did, it would be a cool thing.
Depends on this https://github.com/electron/rfcs/pull/4
This RFC has been around for a long time...
Moved RFC to https://github.com/electron/rfcs/pull/8 due to GitHub bug...
Not much activity yet, but Electron's API WG is starting to meet regularly to work through APIs and RFCs.
API working group meetings have been a success. The Preload Realms RFC was just merged after approval 🎉
Next step is to finish implementing preload realms and open a PR to Electron. I don't have any estimates for how long this will take me, but my hope is we have MV3 supported by end of year, if not sooner 🙏
For anyone interested in this, please consider sponsoring my work 🙇
awesome 😎
Any updates about this?
Implementation work is still ongoing.
Next step is to propose a PR in the Electron repo with support of preload scripts in service workers. Still need to finalize API designs and write more tests & documentation.
I'm able to inject JS into the MV3 service workers so the action badges are partially working now. :)
Great news @samuelmaddock ! I'm glad you are making progress on this.
Opened a PR in Electron to add preload scripts in service workers. https://github.com/electron/electron/pull/44411
This will allow Chrome extension APIs to be implemented in Manifest V3 background workers.
Dark Reader is now working well in the mv3
branch.
Manifest V3 (MV3) is that latest versions of the Chrome extensions API which is now stable in Chrome.
It's partially supported in Electron at the moment since electron/electron#27562 was introduced.
Known affected extensions
I don't know of any widely used extensions shipping with MV3 yet, but there will be as MV2 begins to be phased out.
Possible solutions
electron-chrome-extensions
provides new extension APIs by injecting them with JavaScript. This is done in Electron preload scripts. Instead of background hosts using a WebContents instance, MV3 uses service workers.Electron doesn't have support for injecting JS into a service worker context yet. The API will need to be expanded to support new contexts. Work on specing out changes has started in electron/governance#366