samuelmaddock / metastream

Watch streaming media with friends.
https://getmetastream.com/
2.5k stars 214 forks source link

v0.10.4 causes performance issues #453

Open ChachaNuVaughn opened 3 months ago

ChachaNuVaughn commented 3 months ago

I often like to do something else while watching videos with friends. I've noticed that since the latest update (that fixed the issue with YouTube), Metastream causes noticeable performance issues with... well, anything.

For point or reference, I am doing this with Metastream running on my second screen, while everything else on my main screen. Even trying to type out this message on GitHub in Firefox, I can see a delay in letters appearing after I type them. I also see lag in loading and scrolling through messages in Discord. Worst of all, I see a significant performance drop in games (PSO2 New Genesis, Mabinogi, Second Life, etc).

I believe this is solely due to Metastream's update, as I wasn't seeing this with the previous version (or at least, not as strongly). This performance hit also does not occur when I view a video on its own, outside of Metastream. If I switch Metastream's window to another tab, the performance hit goes away. It also goes away when I enable Interact Mode.... I happen to notice that when this performance hit from Metastream happens, my laptop's fans spin up (and go back down when switching tabs).

If there's any other info I can provide that'll help, or anything I can do to help test a fix, let me know!

samuelmaddock commented 3 months ago

The 0.10.4 update was very small so it's unlikely to cause this much performance impact.

You should try to narrow down the cause further. Does it only occur with YouTube videos? In an older/newer version of Firefox? In Chrome?

Try to update Windows and your graphics drivers as well.

If it is related to YouTube, it may even be an update on their end.

ChachaNuVaughn commented 3 months ago

Hi! Thanks for the response!

1 - Updates: Firefox was outdated slightly, so I've updated it to the latest release (109.0.2). No Windows updates are available, and I'm using the latest AMD drivers available through my laptop's manufacturer (Framework).

2 - Using PSO2 New Genesis as a benchmark with Steam's fps counter, it hovers around 88 fps without Metastream (I have the game limited to a max of 90 fps), and drops to around high 40s to high 50s fps with Metastream. This also still occurs if the video is paused but still the active tab.

3 - The performance drop seems to happen with some video sources, but not all. From what I've tested so far, it happens on YouTube and Pluto TV, but not Odysee or "anime sharing" sites.

4 - I also tested moving the Metastream tab to my primary display (where PSO2 is also being played), and there was no performance drop.... of course, that makes it difficult to game and watch at the same time! So, the drop may be related to my secondary display, or how my laptop communicates with it?

5 - The performance drop does not appear to be occurring with Chrome (128.0.6613.85) or Brave 1.69.153).

6 - My laptop has two GPUs: AMD Radeon 780M (integrated) and AMD Radeon RX 7700S (discrete). I wondered if that might be the issue, as it looks like Firefox is set to run off the integrated GPU. However, Chrome is also set for the integrated GPU (though, Brave is set for the discrete GPU, hmm), and isn't having this issue. *EDIT* I switched Firefox to the discrete GPU and restarted it, and I still get a performance drop from YouTube, etc. However, less of a drop compared to the integrated GPU (drops to around high 60s to low 70s fps)

So... the issue seems to be limited to some video hosts in Firefox and when on secondary screen.