search

samuelmeuli / action-electron-builder

:electron: GitHub Action for building and releasing Electron apps
MIT License
670 stars 206 forks source link

Release still false after tagging #11

Closed d3vhound closed 4 years ago

d3vhound commented 4 years ago

Followed the docs and copied your workfile code and release commit workflow. Still getting release: false for some reason.

Screen Shot 2020-01-24 at 1 31 40 PM
samuelmeuli commented 4 years ago

Can you see whether your tag has been pushed successfully ("Releases" tab on GitHub)?

mririgoyen commented 4 years ago

I am also seeing this. My first release was fine, but I cannot get any other releases to happen. The tags are created correctly, but release: false is always the case now.

samuelmeuli commented 4 years ago

Please check the following:

  1. Make sure your tag is in the format v* and it's pushed correctly.
  2. You're looking at the correct workflow execution (one triggered by a tag push, not a commit push). Tagged commits will have two corresponding workflows.

If this doesn't help: The release value is set to ${{ startsWith(github.ref, 'refs/tags/v') }} in the README example, so this would indicate that the actual ref is different. Could you try logging the ref and checking if/why it doesn't start with refs/tags/v?

mririgoyen commented 4 years ago

There was the problem. I specified branches for push, which begins ignoring tag pushes. I had to explicitly add those.

  push:
    tags:
      - v*

That solved my issue. Perhaps @d3vhound has a similar issue.