search

samuelmeuli / action-electron-builder

:electron: GitHub Action for building and releasing Electron apps
MIT License
658 stars 201 forks source link

Update sample workflow to only run on tags #20

Closed IliasHad closed 4 years ago

samuelmeuli commented 4 years ago

Hi @IliasHad, thanks for the PR! Could you please share your motivation for the change to the sample workflow?

IliasHad commented 4 years ago

Hi @samuelmeuli ,

I use the workflow example in my electron app and the app was successfully build but it didn't upload the build app to the release

samuelmeuli commented 4 years ago

I'd like to keep it the way it is. Having the action run on every commit lets you know early if you broke something that makes the electron-builder command fail. And it's a sample workflow, so it's better to keep it as simple as possible.