samuelmeuli / action-electron-builder

:electron: GitHub Action for building and releasing Electron apps
MIT License
658 stars 201 forks source link

TypeError [ERR_UNESCAPED_CHARACTERS]: Request path contains unescaped characters #26

Closed laszukdawid closed 4 years ago

laszukdawid commented 4 years ago

I'm not sure what's the problem and what is causing it, so I guess I'm asking more for a help.

Pollytron is an app based on electron-react-boilerplate. I'm trying to add your action but I'm ending up with ER_UNESCAPED_CHARACTERS. It's not clear to me what is the url that's not escaped as I'm not setting any (explicitly). Would you mind helping me to debug the problem?

Here are logs from the actions build: https://github.com/laszukdawid/pollytron/runs/660183766?check_suite_focus=true

The error stack trace comes up 3 times, just after unloading step:

 Error #1 --------------------------------------------------------------------------------
TypeError [ERR_UNESCAPED_CHARACTERS]: Request path contains unescaped characters
    at new ClientRequest (_http_client.js:116:13)
    at request (https.js:289:10)
    at NodeHttpExecutor.createRequest (/home/runner/work/pollytron/pollytron/node_modules/builder-util/src/nodeHttpExecutor.ts:9:12)
    at cancellationToken.createPromise (/home/runner/work/pollytron/pollytron/node_modules/builder-util-runtime/src/httpExecutor.ts:84:28)
    at Promise (/home/runner/work/pollytron/pollytron/node_modules/builder-util-runtime/src/CancellationToken.ts:84:7)
    at new Promise (<anonymous>)
    at CancellationToken.createPromise (/home/runner/work/pollytron/pollytron/node_modules/builder-util-runtime/src/CancellationToken.ts:62:12)
    at NodeHttpExecutor.doApiRequest (/home/runner/work/pollytron/pollytron/node_modules/builder-util-runtime/src/httpExecutor.ts:83:30)
    at NodeHttpExecutor.request (/home/runner/work/pollytron/pollytron/node_modules/builder-util-runtime/src/httpExecutor.ts:73:17)
    at GitHubPublisher.githubRequest (/home/runner/work/pollytron/pollytron/node_modules/electron-publish/src/gitHubPublisher.ts:253:35)
    at GitHubPublisher.getOrCreateRelease (/home/runner/work/pollytron/pollytron/node_modules/electron-publish/src/gitHubPublisher.ts:91:33)
    at Lazy.GitHubPublisher._release (/home/runner/work/pollytron/pollytron/node_modules/electron-publish/src/gitHubPublisher.ts:30:102)
    at Lazy.get value [as value] (/home/runner/work/pollytron/pollytron/node_modules/lazy-val/src/main.ts:18:25)
    at GitHubPublisher.doUpload (/home/runner/work/pollytron/pollytron/node_modules/electron-publish/src/gitHubPublisher.ts:163:41)
    at GitHubPublisher.upload (/home/runner/work/pollytron/pollytron/node_modules/electron-publish/src/publisher.ts:86:16)
samuelmeuli commented 4 years ago

Looks unrelated to this action, please ask here: https://github.com/electron-userland/electron-builder/issues

laszukdawid commented 4 years ago

Ok, thanks for the reply. I'll ask in referred repo, although I don't see any problems when packaging locally.