samuelmeuli / action-electron-builder

:electron: GitHub Action for building and releasing Electron apps
MIT License
670 stars 206 forks source link

Add option to set yarn network-timeout #43

Open tytremblay opened 4 years ago

tytremblay commented 4 years ago

I must have some huge dependency somewhere that caused my windows builds to fail with the following error:

Installing dependencies using Yarn…
yarn install v1.22.4
$ node ./internals/scripts/CheckYarn.js
[1/4] Resolving packages...
[2/4] Fetching packages...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
error An unexpected error occurred: "https://registry.yarnpkg.com/@material-ui/icons/-/icons-4.9.1.tgz: ESOCKETTIMEDOUT".
info If you think this is a bug, please open a bug report with the information provided in "D:\\a\\frc-video-splitter-3\\frc-video-splitter-3\\yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
child_process.js:660
    throw err;

I added my own yarn step to install the dependencies with a (much) longer timeout before action-electron-builder, but I feel this is redundant because action-electron-builder just trys to install them in the next step.

      - name: Install dependencies
        run: yarn install --network-timeout 600000

I'd be great if we could specify yarn arguments in this action.