search

samuelmeuli / action-electron-builder

:electron: GitHub Action for building and releasing Electron apps
MIT License
658 stars 201 forks source link

App build work, but artifacts are not publishing #6

Closed vitalykarasik closed 4 years ago

vitalykarasik commented 4 years ago

Thank you for your great project! I cloned your mini-diary repo and played with builds. Build action is triggered, build is OK, but artifacts are not publishing. As far as I understand from your documentation, build action is publishing by default. Am I wrong? When I run build manually on my MacOS, 'yarn build' builds app, and 'electron-builder build --mac --win --publish always' builds and publishes.

Thank you again, Vitaly

samuelmeuli commented 4 years ago

Hi Vitaly,

By default, the action won't create a release and will simply build the app. You can control that behavior with the release parameter.

What I have in the README is simply a sample workflow of how the action could be used. Have a look at this section: In the sample workflow, GitHub Actions will set the release parameter to true if a matching Git tag is found, and otherwise it will be set to false. So if you'd like to create a release with the sample workflow, you'll need to create a tag as described in the README.

Hope this helps :)

vitalykarasik commented 4 years ago

Got it, thank you!