samuelmeuli / action-electron-builder

:electron: GitHub Action for building and releasing Electron apps
MIT License
658 stars 201 forks source link

update actions checkout@v3 setup-node@v3 with node16 #94

Closed heliomarpm closed 3 months ago

heliomarpm commented 1 year ago

Update

gregorym commented 1 year ago

bump

marcofugaro commented 1 year ago

@samuelmeuli could we merge this? otherwise this actions is dead

teavver commented 11 months ago

@samuelmeuli

megahirt commented 4 months ago

Looks like this action is dead. We now need actions/checkout@v4 and actions/setup-node@v4 to get rid of node 16 warnings

heliomarpm commented 4 months ago

Looks like this action is dead. We now need actions/checkout@v4 and actions/setup-node@v4 to get rid of node 16 warnings

I have made an updated version available https://github.com/marketplace/actions/electron-builder-action-all-in-one

megahirt commented 4 months ago

Looks like this action is dead. We now need actions/checkout@v4 and actions/setup-node@v4 to get rid of node 16 warnings

I have made an updated version available https://github.com/marketplace/actions/electron-builder-action-all-in-one

@heliomarpm excellent! Thank you for maintaining a fork and fixing this up! I went to the fork but don't see an issue tracker (maybe that's intentional).

A request: could you name the tags with a 'v' e.g. 'v2.1'. Currently you have just '2.1' which means that this fork isn't a drop in replacement for the samuelmeuli action - the version format also needs to be changed

heliomarpm commented 4 months ago

Parece que essa ação está morta. Agora precisamos de ações/checkout@v4 e ações/setup-node@v4 para nos livrarmos dos avisos do nó 16

Disponibilizei uma versão atualizada https://github.com/marketplace/actions/electron-builder-action-all-in-one

Excelente! Obrigado por manter um garfo e consertar isso! Eu fui para o fork, mas não vejo um rastreador de problemas (talvez isso seja intencional).

Um pedido: você poderia nomear as tags com um 'v', por exemplo, 'v2.1'. Atualmente você tem apenas '2.1', o que significa que este fork não é uma gota em substituição para a ação samuelmeuli - o formato da versão também precisa ser alterado

Ok @megahirt , I'll do it. tks