search

samuelmr / nordpool-node

A npm library to get information from nordic power market (Nord Pool, ELSPOT)
MIT License
55 stars 12 forks source link

Move to typescript to make work from typescript as well as normal node #18

Closed lekkimworld closed 1 year ago

lekkimworld commented 1 year ago

I have been using the library for a while but after my move to typescript and es6 modules I couldn't make it work anymore so I converted the source to typescript to make it work as well as provide types. I wanted to provide it back to you in case you would like to adopt this. If not I'll just continue using my own fork.

The tests are passing but the source could probably be cleaned a bit. If you would like to merge this PR let me know and I'll do that before you merge.

Thank you for building this.

lekkimworld commented 1 year ago

I just published this module under @lekkim/nordpool on npm if you would like to try it out.

lekkimworld commented 1 year ago

Maybe it's just me but I never check in generated assets into git so the lib folder that has the compiled source and types are not in npm package you uploaded as v 5.0.0. I suggest you checkout the source and do a npm run build and then republish the package to npm. Sorry about that.

samuelmr commented 1 year ago

It seems you wrote your comment just after I had done npm run build and published 5.0.1 :)