search

samuelmr / oura

Unofficial ŌURA cloud API client for node.js
ISC License
26 stars 5 forks source link

Updated servie dependency which was causing errors #5

Open aymather opened 5 years ago

aymather commented 5 years ago

I was getting errors from http response headers that had numeric values. Turns out this was fixed in the servie package a little while back, just needed to update it from 4.2.1 to 4.3.1

samuelmr commented 5 years ago

Thanks for the PR!

Instead of modifying package-lock.json directly, can you check what's the dependency path to servie? I'd rather update the versions of direct dependencies in package.json.

The oura package works for me without errors. Can you describe the issue you had with response headers?

aymather commented 5 years ago
Screen Shot 2019-09-26 at 12 55 16 PM

This was the issue I was having with http responses. I investigated and found that the headers were returning "number" types like this:

Screen Shot 2019-09-26 at 12 56 36 PM

I talked to the creator of servie and he said that was fixed in the v4.3 update. When I updated the package from v4.2.1 to v4.3.1 I was able to get it working again.

I don't know which dependency is leaning on servie. I can do some investigating!

aymather commented 5 years ago

Ok so to be honest I don't really know what you mean by "dependency path." But I realized that I didn't have to modify the package-lock.json directly, you can fix the problem by deleting the package-lock.json and running npm install which will make the necessary modifications. Essentially doing the same thing as changing it manually though.