Closed bjarmuz closed 7 years ago
Thank you for your contribution. I'd request a minor change before merging.
Adding an optional parameter this was is not compatible with already-compiled clients. If someone updates this code and uses it with clients that are not recompiled, they will get an exception about the method not being found. Optional arguments are filled in at compile time.
Instead please add overload that accepts the optional boolean and have the existing method keep its signature and call the overload appropriately.
Sam
Fair enough, I've submitted a change :) Cheers!
Thanks for the contribution and making that change.
Add option to NOT throw an error if mimeType is not registered.